Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esdt-safe: Fix withdraw total fees on ethereum #221

Merged
merged 6 commits into from
Oct 10, 2024
Merged

esdt-safe: Fix withdraw total fees on ethereum #221

merged 6 commits into from
Oct 10, 2024

Conversation

CostinCarabas
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Coverage Summary

Totals

Count Covered %
Lines 11100 5724 51.57
Regions 1781 956 53.68
Functions 1009 482 47.77
Instantiations 5065 1197 23.63

Files

Expand
File Lines Regions Functions Instantiations
/home/runner/.cargo/git/checkouts/mx-contracts-rs-13011bd47afef959/d91bbff/contracts/crowdfunding-esdt/src/crowdfunding_esdt.rs 51.56% 57.14% 77.78% 64.00%
/home/runner/.cargo/git/checkouts/mx-contracts-rs-13011bd47afef959/d91bbff/contracts/crowdfunding-esdt/src/crowdfunding_esdt_proxy.rs 100.00% 100.00% 100.00% 100.00%
/bridge-proxy/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/bridge-proxy/src/bridge-proxy.rs 56.90% 66.00% 61.54% 19.69%
/bridge-proxy/src/bridge_proxy_contract_proxy.rs 45.88% 44.44% 44.44% 50.00%
/bridge-proxy/src/bridged_tokens_wrapper_proxy.rs 24.61% 25.00% 25.00% 15.00%
/bridge-proxy/src/config.rs 60.71% 53.33% 75.00% 21.74%
/bridge-proxy/src/esdt_safe_proxy.rs 0.00% 0.00% 0.00% 0.00%
/bridge-proxy/tests/bridge_proxy_blackbox_test.rs 97.16% 96.00% 90.00% 90.00%
/bridged-tokens-wrapper/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/bridged-tokens-wrapper/src/dfp_big_uint.rs 100.00% 100.00% 100.00% 43.48%
/bridged-tokens-wrapper/src/esdt_safe_proxy.rs 2.71% 3.85% 3.85% 3.23%
/bridged-tokens-wrapper/src/events.rs 100.00% 33.33% 100.00% 5.88%
/bridged-tokens-wrapper/src/lib.rs 99.10% 96.88% 100.00% 23.97%
/bridged-tokens-wrapper/tests/bridged_tokens_wrapper_whitebox_test.rs 90.26% 91.28% 90.62% 90.62%
/bridged-tokens-wrapper/tests/dfp_big_uint_test.rs 100.00% 100.00% 100.00% 100.00%
/bridged-tokens-wrapper/tests/scenario_go_test.rs 100.00% 100.00% 100.00% 100.00%
/common/eth-address/src/lib.rs 93.33% 66.67% 88.89% 46.74%
/common/fee-estimator-module/src/lib.rs 100.00% 93.75% 100.00% 19.83%
/common/fee-estimator-module/src/price_aggregator_proxy.rs 6.14% 4.76% 6.67% 5.26%
/common/max-bridged-amount-module/src/lib.rs 100.00% 87.50% 100.00% 17.48%
/common/token-module/src/lib.rs 68.33% 62.20% 76.19% 22.59%
/common/transaction/src/lib.rs 45.28% 45.10% 58.33% 21.56%
/common/transaction/src/transaction_status.rs 83.33% 66.67% 83.33% 29.79%
/common/tx-batch-module/src/batch_status.rs 33.33% 25.00% 33.33% 7.14%
/common/tx-batch-module/src/lib.rs 81.25% 72.60% 87.50% 19.36%
/common/tx-batch-module/src/tx_batch_mapper.rs 92.54% 89.66% 100.00% 33.75%
/esdt-safe/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/esdt-safe/src/lib.rs 54.97% 43.94% 65.52% 17.36%
/esdt-safe/tests/esdt_safe_scenario_rs_test.rs 100.00% 100.00% 100.00% 100.00%
/esdt-safe/tests/scenario_go_test.rs 100.00% 100.00% 100.00% 100.00%
/multi-transfer-esdt/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/multi-transfer-esdt/src/bridge_proxy_contract_proxy.rs 8.24% 11.11% 11.11% 15.38%
/multi-transfer-esdt/src/bridged_tokens_wrapper_proxy.rs 41.80% 41.67% 41.67% 41.67%
/multi-transfer-esdt/src/esdt_safe_proxy.rs 20.70% 17.31% 17.31% 16.67%
/multi-transfer-esdt/src/lib.rs 61.14% 60.66% 68.75% 25.33%
/multi-transfer-esdt/src/multi_transfer_proxy.rs 37.32% 38.10% 38.10% 40.00%
/multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs 100.00% 100.00% 100.00% 100.00%
/multi-transfer-esdt/tests/multi_transfer_esdt_scenario_rs_test.rs 57.14% 30.00% 30.00% 30.00%
/multi-transfer-esdt/tests/scenario_go_test.rs 30.00% 30.00% 30.00% 30.00%
/multisig/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/multisig/src/action.rs 25.00% 22.22% 33.33% 30.77%
/multisig/src/bridge_proxy_contract_proxy.rs 0.00% 0.00% 0.00% 0.00%
/multisig/src/esdt_safe_proxy.rs 23.89% 21.15% 21.15% 12.12%
/multisig/src/events.rs 100.00% 66.67% 100.00% 12.90%
/multisig/src/lib.rs 70.23% 71.05% 70.00% 25.66%
/multisig/src/multi_transfer_esdt_proxy.rs 19.00% 22.73% 22.73% 13.64%
/multisig/src/multisig_general.rs 80.00% 65.38% 75.00% 30.77%
/multisig/src/multisig_proxy.rs 15.38% 12.24% 14.12% 13.86%
/multisig/src/queries.rs 64.52% 61.76% 57.89% 15.79%
/multisig/src/setup.rs 25.97% 32.61% 25.81% 7.00%
/multisig/src/storage.rs 100.00% 66.67% 100.00% 27.41%
/multisig/src/user_role.rs 83.33% 72.73% 75.00% 41.67%
/multisig/src/util.rs 94.44% 84.38% 100.00% 44.12%
/multisig/tests/multisig_blackbox_test.rs 100.00% 100.00% 100.00% 100.00%
/multisig/tests/multisig_scenario_rs_test.rs 82.69% 72.73% 72.73% 72.73%
/multisig/tests/scenario_go_test.rs 70.00% 70.00% 70.00% 70.00%
/test-caller/meta/src/main.rs 0.00% 0.00% 0.00% 0.00%
/test-caller/src/test-caller.rs 0.00% 0.00% 0.00% 0.00%

iulianpascalau
iulianpascalau reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will green after integrating this variant

esdt-safe/src/lib.rs Outdated
self.tx()
.to(ToCaller)
.single_esdt(&token_id, 0, &amount_out)
.transfer();
total_fees_on_ethereum_mapper.set(BigUint::zero());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Contract comparison - from 7063af9 to b1154fa

Path                                                                                             size                  has-allocator                     has-format
test-caller.wasm 3238 false without message
test-caller-dbg.wasm 7109 false without message
esdt-safe.wasm 25219 ➡️ 25769 🔴 false without message
esdt-safe-dbg.wasm 60858 ➡️ 62100 🔴 false without message
multi-transfer-esdt.wasm 17213 false without message
multi-transfer-esdt-dbg.wasm 41043 false without message
bridge-proxy-dbg.wasm 34132 false without message
bridge-proxy.wasm 13056 false without message
bridged-tokens-wrapper.wasm 9541 false without message
bridged-tokens-wrapper-dbg.wasm 27239 false without message
multisig-dbg.wasm 71576 ➡️ 72029 🔴 false without message
multisig.wasm 29125 ➡️ 29330 🔴 false without message

evelinemolnar
evelinemolnar previously approved these changes Oct 9, 2024
View reviewed changes
CostinCarabas
CostinCarabas commented Oct 9, 2024
View reviewed changes
esdt-safe/src/lib.rs Outdated Show resolved Hide resolved
CostinCarabas
CostinCarabas commented Oct 9, 2024
View reviewed changes
esdt-safe/src/lib.rs Outdated Show resolved Hide resolved
@CostinCarabas CostinCarabas self-assigned this Oct 9, 2024
evelinemolnar
evelinemolnar previously approved these changes Oct 9, 2024
View reviewed changes
@iulianpascalau iulianpascalau mentioned this pull request Oct 9, 2024
Merged
@iulianpascalau iulianpascalau merged commit dba9227 into feat/v3 Oct 10, 2024
5 checks passed
@iulianpascalau iulianpascalau deleted the fix/withdraw-total-fees-on-ethereum branch October 10, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evelinemolnar evelinemolnar evelinemolnar approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

Assignees

@CostinCarabas CostinCarabas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CostinCarabas @iulianpascalau @evelinemolnar